On Mon, Jun 8, 2015 at 10:26 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Mon, Jun 8, 2015 at 3:48 PM, Michael Paquier > <michael.paqu...@gmail.com> wrote: >> Hi all, >> >> Please find attached a set of fixes for a couple of things in src/bin: >> - pg_dump/pg_dumpall: >> -- getFormattedTypeName, convertTSFunction and myFormatType return >> strdup'd results that are never free'd. >> -- convertTSFunction returns const char. I fail to see the point of >> that... In my opinion we are fine with just returning a char pointer, >> which is strdup'd so as it can be freed by the caller. >> - initdb's and pg_regress' use getaddrinfo, but do not free the >> returned result with freeaddrinfo(). >> - Coverity noticed on the way some leaked memory in pg_upgrade's >> equivalent_locale(). >> >> Those issues have been mostly spotted by Coverity, I may have spotted >> some of them while looking at similar code paths... In any case that's >> Coverity's win ;) > > Attached are new patches, I simplified the use of free in the fixes of > pg_dumpall.
Please ignore those versions, I am just too sleepy... -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
