On Thu, Jun 11, 2015 at 1:39 AM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > Fujii Masao wrote: > >> Agreed. The attached patch defines the macro to check whether archiver is >> allowed to start up or not, and uses it everywhere except sigusr1_handler. >> I made sigusr1_handler use a different condition because only it tries to >> start archiver in PM_STARTUP postmaster state and it looks a bit messy >> to add the check of that state into the centralized check condition. > > WFM, but do these macros in xlog.h need a one-line comment to state > their purpose?
Yes, I added the comments and just pushed the patch. Thanks! Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
