On 2015-06-19 09:08, Brendan Jurd wrote:
On Sun, 14 Jun 2015 at 20:44 Petr Jelinek <p...@2ndquadrant.com
<mailto:p...@2ndquadrant.com>> wrote:
looks like I omitted psql tab completion from the TABLESAMPLE patch. The
attached patch adds it.
Hi Petr,
I'm doing an initial review of this patch.
Thanks
With the patch applied, psql correctly offers a list of existing
tablesample methods for completion whenever the previous word is
'TABLESAMPLE'. I did notice that the syntax of the TABLESAMPLE clause
requires brackets after the method name, but the tab completion does not
complete the opening bracket. Whereas, say, ALTER FUNCTION does. I
think it would be convenient and user-friendly to complete the opening
bracket -- it would make it perfectly clear that an argument is required
for the syntax to be valid.
Agreed, here is updated version which does that.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index b9f5acc..c295ffa 100644
--- a/src/bin/psql/tab-complete.c
+++ b/src/bin/psql/tab-complete.c
@@ -737,6 +737,11 @@ static const SchemaQuery Query_for_list_of_matviews = {
" FROM pg_catalog.pg_event_trigger "\
" WHERE substring(pg_catalog.quote_ident(evtname),1,%d)='%s'"
+#define Query_for_list_of_tablesample_methods \
+" SELECT pg_catalog.quote_ident(tsmname) "\
+" FROM pg_catalog.pg_tablesample_method "\
+" WHERE substring(pg_catalog.quote_ident(tsmname),1,%d)='%s'"
+
/*
* This is a list of all "things" in Pgsql, which can show up after CREATE or
* DROP; and there is also a query to get a list of them.
@@ -3578,6 +3583,13 @@ psql_completion(const char *text, int start, int end)
prev2_wd[0] == '\0')
COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_relations, NULL);
+/* TABLESAMPLE */
+ else if (pg_strcasecmp(prev_wd, "TABLESAMPLE") == 0)
+ COMPLETE_WITH_QUERY(Query_for_list_of_tablesample_methods);
+
+ else if (pg_strcasecmp(prev2_wd, "TABLESAMPLE") == 0)
+ COMPLETE_WITH_CONST("(");
+
/* TRUNCATE */
else if (pg_strcasecmp(prev_wd, "TRUNCATE") == 0)
COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_tables, NULL);
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
