On Sat, Jun 27, 2015 at 07:20:43PM -0400, Tom Lane wrote: > Tatsuo Ishii <is...@postgresql.org> writes: > >> I noticed that in EXEC_BACKEND builds (ie, Windows) the pg_file_settings > >> view doesn't act as its author presumably intended. Specifically, it > >> reads as empty until/unless the current session processes a SIGHUP event. > > > I'm just wondering why we did not catch this earlier. If this is > > because threre's no regression test case for pg_file_settings view, > > Yeah, exactly. Unfortunately I see no way to add a useful test, at least > not one that will work in installcheck mode. There's no way to predict > what will be in the view in that case. Even for "make check", the output > would be pretty darn environment-dependent.
A TAP test case is the way to test this thoroughly. It could feed any number of specific postgresql.conf variations to a postmaster. See src/bin/pg_ctl/t/002_status.pl for a test doing something similar. (Granted, I would not have thought to write such a test for this feature.) -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
