-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 07/05/2015 12:25 PM, Joe Conway wrote: > On 02/22/2015 10:26 PM, Corey Huinker wrote: >> Changes in this patch: - added polymorphic versions of >> dblink_fetch() - upped dblink version # to 1.2 because of new >> functions - migration 1.1 -> 1.2 - DocBook changes for dblink(), >> dblink_get_result(), dblink_fetch() > > The previous patch was missing dblink--1.1--1.2.sql and > dblink--1.2.sql. I have added them, so it should apply cleanly > against git master, but not done any actual review yet.
Looking at the argument handling logic in dblink_fetch() and dblink_record_internal(), it has been messy for a while, but this patch serves to make it even worse. I wonder if it isn't better to just loop through all the args with get_fn_expr_argtype() every time and then test for the exact signature match? Another alternative might be to create a wrapper C function for each variant SQL function, but that seems like it could also get messy, especially with dblink_record_internal() since we would have to deal with every variant of all the external facing callers. Thoughts? - -- Joe Conway -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJVmdM8AAoJEDfy90M199hldowQAJ8F14qSJC9BIGdxKwRIDCS2 bzbWoynYhGiDmvffmD3e3MAUrFwh+zS3QIN5BcJVBrdLnzjZIgHFz83Z1iuH1HVw 39z0sSZVJ0C7DvPV6UiNoDpKnyAJQUu3+A5ebWKj5AYOA0AVunA7J1vSMfXAYThV zQ6lYEpCOFq0owIyjUFpjvXUSZFs6AHEQC5wQ/UW+EXCZKl0OYQtSf8oxi8m4DFu xRrjM+bO7LmOrBPa5fPvQOXHr5KJRjq9x7CfU+a8mJaJh4r1MmDRp7iLVxlMae0k YVdmsLP9FOS+RhAdmmKHsTWiEJIFhffKWqcahBXGdOOWjzUVzih/LAL0BS2z44AU ygVW/ORg5ua7Y4zxg4PUKbIkvhA+qRs0WUpuY+nYZoYAayP3VqsWP3VvMYb/e/Fb nyws+/C1wC2aIQxgoF/+Whdfh4eTcFMSK9Qsc0pdMleDizz9O0qauHWzglo89x8X t+s2zNnmZ0NtWd4PSTcMAcq59v288CoKDME+gjT7A6jthEbBnkx6SdEjh/NLhJba dKKv99ZP0Rg5v8pFpQ/3TzdBB1UifUz3nd6ubeWNPjAdBbiW1FFD+I6booPmaxh0 EOYLBVkVgJFgaz0bWI5P6bDi55LDQlUQEfLRE3dxoNdffivNNfElOkXly4VShB4i YlCc/0A1opGZb3iJwo4X =8VAQ -----END PGP SIGNATURE----- -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers