On Wed, Jul 29, 2015 at 5:22 AM, Heikki Linnakangas wrote: > On 07/28/2015 11:01 PM, Alvaro Herrera wrote: >>>> Improving test coverage of extensions with pg_dump >>> >>> >>> Do we want to have this in src/test/modules or src/bin/pg_dump/t? >> >> >> Are we testing pg_dump here, or are we testing extensions? If the >> former, src/bin/pg_dump/t seems best.
All the tests are using pg_dump, but it is testing dumpable tables in an extension. At this point I am not sure which one is better honestly X/. Putting it in pg_dump/t will require two lines in the make target prove_check such as modules in this path are installed as well, and the argument against having it in src/test/modules is that it would bloat it in the future if we do the same for all binaries, particularly if we have multiple modules for each one. > I think that's the crux of the disagreement :-). Yep. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
