On Tue, Jul 7, 2015 at 9:14 PM, Andres Freund <and...@anarazel.de> wrote:
> On 2015-06-19 06:41:19 +0000, Brendan Jurd wrote:
>> I'm marking this "Waiting on Author". Once the problems have been
>> corrected, it should be ready for a committer.
>
> Vik, are you going to update the patch?
Seeing no activity on this thread and as it would be a waste not to do
it, I completed the patch as attached. The following things are done:
- Fixed code indentation
- Removal of "RESTART", "SET SCHEMA", "OWNER TO", and "RENAME TO" in
CREATE SEQUENCE
- Added "START WITH".
- Added TEMP/TEMPORARY in the set of keywords tracked.
I am switching at the same time this patch as "Ready for committer".
Regards,
--
Michael
diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index ece0515..0748284 100644
--- a/src/bin/psql/tab-complete.c
+++ b/src/bin/psql/tab-complete.c
@@ -2467,6 +2467,35 @@ psql_completion(const char *text, int start, int end)
pg_strcasecmp(prev_wd, "TO") == 0)
COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_tables, NULL);
+/* CREATE TEMP/TEMPORARY SEQUENCE <name> */
+ else if ((pg_strcasecmp(prev3_wd, "CREATE") == 0 &&
+ pg_strcasecmp(prev2_wd, "SEQUENCE") == 0) ||
+ (pg_strcasecmp(prev4_wd, "CREATE") == 0 &&
+ (pg_strcasecmp(prev3_wd, "TEMP") == 0 ||
+ pg_strcasecmp(prev3_wd, "TEMPORARY") == 0) &&
+ pg_strcasecmp(prev2_wd, "SEQUENCE") == 0))
+ {
+ static const char *const list_CREATESEQUENCE[] =
+ {"INCREMENT BY", "MINVALUE", "MAXVALUE", "RESTART", "NO", "CACHE",
+ "CYCLE", "OWNED BY", "START WITH", NULL};
+
+ COMPLETE_WITH_LIST(list_CREATESEQUENCE);
+ }
+/* CREATE TEMP/TEMPORARY SEQUENCE <name> NO */
+ else if ((pg_strcasecmp(prev4_wd, "CREATE") == 0 &&
+ pg_strcasecmp(prev3_wd, "SEQUENCE") == 0) ||
+ (pg_strcasecmp(prev5_wd, "CREATE") == 0 &&
+ (pg_strcasecmp(prev4_wd, "TEMP") == 0 ||
+ pg_strcasecmp(prev4_wd, "TEMPORARY") == 0) &&
+ pg_strcasecmp(prev3_wd, "SEQUENCE") == 0) &&
+ pg_strcasecmp(prev_wd, "NO") == 0)
+ {
+ static const char *const list_CREATESEQUENCE2[] =
+ {"MINVALUE", "MAXVALUE", "CYCLE", NULL};
+
+ COMPLETE_WITH_LIST(list_CREATESEQUENCE2);
+ }
+
/* CREATE SERVER <name> */
else if (pg_strcasecmp(prev3_wd, "CREATE") == 0 &&
pg_strcasecmp(prev2_wd, "SERVER") == 0)
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
