On 08/13/2015 04:26 PM, Alvaro Herrera wrote:
Alvaro Herrera wrote:
Re-add BRIN isolation test

This time, instead of using a core isolation test, put it on its own
test module; this way it can require the pageinspect module to be
present before running.

The module's Makefile is loosely modeled after test_decoding's, so that
it's easy to add further tests for either pg_regress or isolationtester
later.
Argh, and this now broke MSVC :-(

I'm tempted to change this block from Mkvcbuild.pm,

     else
     {
         croak "Could not determine contrib module type for $n\n";
     }

(i.e. it doesn't find any of PROGRAM, MODULES, MODULE_big in the
Makefile) so that instead of raising an error it simply skips the module
altogether.  That's pretty much equivalent to what Make would do.  Maybe
restrict this behavior to within src/test/modules.



An immediate solution would probably be to add it to @contrib_excludes.

cheers

andrew


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to