-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 08/25/2015 10:32 AM, Joe Conway wrote:
> On 08/25/2015 10:28 AM, Tom Lane wrote:
>> I was suggesting getting rid of "Current" in *all* the entries.
>> What value does it add?
>
> I agree, it adds no value, and is a simple solution.
>
> Does anyone out there object to a non-backward compatible change
> to pg_controldata output?
...specifically the attached. Will commit/push to 9.5 and HEAD in a
few hours barring any objections.
Joe
- --
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
iQIcBAEBAgAGBQJV3LM6AAoJEDfy90M199hlzwUP/0EeobxsxidorFS/4RQRXeWN
Gb879a7brwAIuEZVqP9BdlzhfPWrGx98vyRHvQ4jbcNXXO3fe5xTqklXdSMAJD5L
0hF1+DIVHg+SuZ7hJiW0wl1y0b8OIs2w7WOHwi39ZFV1//dbJkV8DkWG0Ty2Roxf
JXqBrFOLP0nu6sS3jx2tCkGtkAL5b0FvZw6aFiuxvVUYFW8U36VjCVgZ6aEN+7Jn
zvMrMsBtH/AxfhPWd8BblsBhC3+ShPPdG8rE9RHSBwX6qBWlJnf3WAiEjuj6p7Wk
kQluJwxWU13s/IKjqmES+H04fEUeqTNouRDlCEKim7o5d7E1FNDS0gCcQ0oIftco
dtTf192K91+xtnsnQrgODkrk/tZpnCr7ay0LHI+ydIOtmqgX1g3RchoTL37zMohK
sDLEo3aTM4f6mLV2Qbh9ETizcssJuZJoSKKo51icLxbXXUrv8CuU5yniXAm8NM0a
MwyVfJL3gjQhEcP3aRIbvCRVqtQJK2Y8Qiff5uDQ+9Nl3ApdIVuyEp+w9pvK/55Z
w3MdZt5cjphIANjayqfA2B4nSvLE3RC7caJr0HS10yvFAzP2Go4HQUA1t7RFCYI0
zww+ZQ2hrIdiSZu61QnO1DR49WZrQPd1Z/W9gzHHqTFO1IYf+XxBliQk0mTbZUiN
v2DJhvBV2zMhS0jjrVvV
=6223
-----END PGP SIGNATURE-----
diff --git a/src/bin/pg_controldata/pg_controldata.c b/src/bin/pg_controldata/pg_controldata.c
index d8cfe5e..046480c 100644
*** a/src/bin/pg_controldata/pg_controldata.c
--- b/src/bin/pg_controldata/pg_controldata.c
*************** main(int argc, char *argv[])
*** 290,308 ****
(uint32) ControlFile.backupEndPoint);
printf(_("End-of-backup record required: %s\n"),
ControlFile.backupEndRequired ? _("yes") : _("no"));
! printf(_("Current wal_level setting: %s\n"),
wal_level_str(ControlFile.wal_level));
! printf(_("Current wal_log_hints setting: %s\n"),
ControlFile.wal_log_hints ? _("on") : _("off"));
! printf(_("Current max_connections setting: %d\n"),
ControlFile.MaxConnections);
! printf(_("Current max_worker_processes setting: %d\n"),
ControlFile.max_worker_processes);
! printf(_("Current max_prepared_xacts setting: %d\n"),
ControlFile.max_prepared_xacts);
! printf(_("Current max_locks_per_xact setting: %d\n"),
ControlFile.max_locks_per_xact);
! printf(_("Current track_commit_timestamp setting: %s\n"),
ControlFile.track_commit_timestamp ? _("on") : _("off"));
printf(_("Maximum data alignment: %u\n"),
ControlFile.maxAlign);
--- 290,308 ----
(uint32) ControlFile.backupEndPoint);
printf(_("End-of-backup record required: %s\n"),
ControlFile.backupEndRequired ? _("yes") : _("no"));
! printf(_("wal_level setting: %s\n"),
wal_level_str(ControlFile.wal_level));
! printf(_("wal_log_hints setting: %s\n"),
ControlFile.wal_log_hints ? _("on") : _("off"));
! printf(_("max_connections setting: %d\n"),
ControlFile.MaxConnections);
! printf(_("max_worker_processes setting: %d\n"),
ControlFile.max_worker_processes);
! printf(_("max_prepared_xacts setting: %d\n"),
ControlFile.max_prepared_xacts);
! printf(_("max_locks_per_xact setting: %d\n"),
ControlFile.max_locks_per_xact);
! printf(_("track_commit_timestamp setting: %s\n"),
ControlFile.track_commit_timestamp ? _("on") : _("off"));
printf(_("Maximum data alignment: %u\n"),
ControlFile.maxAlign);
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
