On Wed, Sep 9, 2015 at 11:49 PM, Amit Kapila <amit.kapil...@gmail.com> wrote:
> - errdetail("Could not rename \"%s\" to \"%s\": %m.",
> + errdetail("\"%s\" could not be renamed to \"%s\": %m.",
>
> Is there any reason to change this message?
> I think you have changed this message to make it somewhat similar with
> the new message we are planning to use in this function, but I don't see
> that as compelling reason to change this message.The old message better follows the guidelines. See section 51.3.7: Avoid Passive Voice. The old message is what's called "telegram-style", with PostgreSQL itself as the implicit subject. The proposed replacement is just the regular old passive voice. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
