On 9/19/15 10:46 AM, Tom Lane wrote: > Peter Eisentraut <pete...@gmx.net> writes: >> On 7/23/15 6:39 PM, Tom Lane wrote: >>> + 2202H E ERRCODE_INVALID_TABLESAMPLE_ARGUMENT >>> invalid_tablesample_argument >>> + 2202G E ERRCODE_INVALID_TABLESAMPLE_REPEAT >>> invalid_tablesample_repeat > >> Where did you get these error codes from? The constants in the SQL >> standard would map to > >> ERRCODE_INVALID_SAMPLE_SIZE >> ERRCODE_INVALID_REPEAT_ARGUMENT_IN_A_SAMPLE_CLAUSE > >> Were you looking at a different standard, or did you intentionally >> choose to rephrase? > > I was looking at SQL:2011. My concern in naming them that way was that > I wanted to have errcodes that would be general enough for any tablesample > extension to use, but still be tablesample-specific, ie I don't want them > to have to fall back on say ERRCODE_INVALID_PARAMETER_VALUE.
Makes sense. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
