On Wed, Sep 23, 2015 at 5:42 AM, Robert Haas <robertmh...@gmail.com> wrote: > > On Tue, Sep 22, 2015 at 3:21 PM, Amit Kapila <amit.kapil...@gmail.com> wrote:
> > readAttrNumberCols uses sizeof(Oid) instead of sizeof(AttrNumber). > > I still don't understand why we need to handle PlanInvalItem. As such this is not required, just to maintain consistency as I have added other similar nodes like PlanRowMark and NestLoopParam. > > Actually, come to think of it, I'm not sure we need PlannedStmt > either. > PlannedStmt is needed because we are passing the same from master to worker for execution and the reason was that Executor interfaces expect it. With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
