On Tue, Sep 29, 2015 at 6:16 PM, Joshua Elsasser <j...@idealist.org> wrote: > ---
Hi! Thanks for submitting patches to the PostgreSQL community. We need more developers, and appreciate contributions. However, I'm somewhat flummoxed by this particular patch series, because (1) there's no real explanation of what these patches are trying to accomplish (e.g. this one has zero explanation other than the subject line), and (2) they seem to be a mix of bug fixes and new features and general refactoring. Bug fixes we will want to back-patch to all supported releases, but features should just go into master. It's helpful if you can explain what falls into which category. Do some of these patches have dependencies on others? If so, it would be helpful to explain that. I'm not inclined to bother with the refactoring patches unless they enable some other thing that we agree is a worthwhile goal. Moving 20 lines of code into a function is something that could be done in a lot of places in our source base, but it doesn't seem like a worthy goal unto itself. It would probably be a good idea to review https://wiki.postgresql.org/wiki/Submitting_a_Patch -- the Linux style of patch submission is generally not preferred here; we like to discuss closely-related patches as a group, on a single thread, and separate patches on completely separate threads. Thanks, -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
