On Mon, Oct 12, 2015 at 4:15 PM, Robert Haas <robertmh...@gmail.com> wrote: > In this case, I think > the best thing for me to do right now is wait to commit anything > further until you have had a chance to go over this and come up with a > fix or set of fixes that you think are completely, 100% ready to go; > or else until you get to the point of wanting feedback before > proceeding further. In general, I would appreciate if this sort of > post-commit self-review could be done pre-commit.
This came to me while I was making dinner last night - I was not actually poring over the code on my computer. I don't know why I thought of it then and not at any earlier point, but it seems reasonable to suppose it had something to do with perspective, or being able to see a bigger picture that is difficult to keep in mind during initial development and self review. I was mostly thinking about external sorting at the time, and not this patch. I cannot do that on demand. It isn't a matter of effort. When I come back from vacation at the end of the month, I may be able to do somewhat better for a few months. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers