On Пт, 2015-10-16 at 09:02 +0530, Amit Kapila wrote: > On Thu, Oct 15, 2015 at 8:35 PM, Dmitry Vasilyev <d.vasilyev@postgres > pro.ru> wrote: > > I think that function dsm_impl_windows() with EACCES error should > > not > > do ereport() with FATAL level. It works, but it is likely to make > > an > > infinite loop if the user will receive EACCES error. > > > > > Currently we are using error level as ERROR for creating dsm during > postmaster startup which is not right and rather we should use error > level as LOG. Can you please try with the attached patch and see > if the issue is fixed for you. > > Another some what related point is currently we are using random() > function to ensure a unique name for dsm and it seems to me that > it is always going to generate same number on first invocation (at > least > thats what happening on windows) due to which you are seeing the > error. Another options could be to append current pid or data > directory > path as we are doing in win32_shmem.c. I think this could be an > optimization which can be done in addition to the fix attached (we > can > do this as a separate patch as well, if we agreed to do anything). > > > With Regards, > Amit Kapila. > EnterpriseDB: http://www.enterprisedb.com
In that case your patch is working. There was LOG level message with Permission denied (from the operation point it’s not clear how to respond to message like this). But as I understand if operating system can’t create shared memory we will try to distinguish that chunk up to infinity. As I see it’s better to stop instance in this case. So I guess it’s a good idea to remain all as it is now (FATAL level) but add PostmasterPid to name (as you suggest). There’s patch in attachments. ---- Dmitry Vasilyev Postgres Professional: http://www.postgrespro.com Russian Postgres Company
diff --git a/src/backend/storage/ipc/dsm_impl.c b/src/backend/storage/ipc/dsm_impl.c index 921f029..55335bf 100644 --- a/src/backend/storage/ipc/dsm_impl.c +++ b/src/backend/storage/ipc/dsm_impl.c @@ -68,6 +68,7 @@ #include "utils/guc.h" #include "utils/memutils.h" #include "postmaster/postmaster.h" +#include "miscadmin.h" #ifdef USE_DSM_POSIX static bool dsm_impl_posix(dsm_op op, dsm_handle handle, Size request_size, @@ -631,7 +632,7 @@ dsm_impl_windows(dsm_op op, dsm_handle handle, Size request_size, * similar to main shared memory. We can change here once issue mentioned * in GetSharedMemName is resolved. */ - snprintf(name, 64, "%s.%u", SEGMENT_NAME_PREFIX, handle); + snprintf(name, 64, "%s.%d.%u", SEGMENT_NAME_PREFIX, PostmasterPid, handle); /* * Handle teardown cases. Since Windows automatically destroys the object
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
