On Tue, Oct 20, 2015 at 1:05 AM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > > Fabien COELHO wrote: > > > >4) It's a bit dubious to only pgstat_send_bgwriter() when on schedule. > > > > No opinion! > > My guess here, without looking, is that this was based on the idea of > "oops, we're late here for the checkpoint, let's do as less work as > possible to avoid getting even later", and thus skip some "unnecessary" > tasks. >
I also think thats what could be the reason for writing the code that way, it seems to me that processing config file when not on schedule has an advantage such that if user has modified checkpoint related parameters (like checkpoint_completion_target), that could improve the checkpoint behaviour. Now there could be some negative impact of this change as well if user changes full_page_writes parameter, as to process that, it needs to write a WAL record which could be costly when the checkpoint is not on schedule, but I think the odds of that are less, so there doesn't seem to be any harm in changing this behaviour. With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
