Peter Geoghegan <p...@heroku.com> writes:
> While auditing the access method code associated with ON CONFLICT DO
> UPDATE's speculative insertion infrastructure, I noticed an
> inaccuracy.

> Attached patch fixes the trivial inaccuracy in a defensive elog()
> call. Quite simply, this call site didn't get the memo when we renamed
> that function during the late stages of development.

This seems like a fine teaching moment in which to point out our
longstanding error message style guideline that says not to put
names of C functions into error messages in the first place.

                        regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to