On Thu, Oct 29, 2015 at 05:39:36PM +0900, Tatsuo Ishii wrote: > > I am happy to finish it, but I am no less happy if you finish it. Which do > > you prefer? > > Please go ahead and commit. > > > Should the back-branch commits mirror the master branch? A more-cautious > > alternative would be to, in back branches, wrap the change in #ifdefs so it > > takes effect only on Windows, OpenBSD and NetBSD. It could break setups > > with > > local firewall rules that block connections to "127.0.0.1" or "::1" without > > blocking "0.0.0.0" or "::". Such firewall rules sound outlandish enough > > that > > I would be fairly comfortable not worrying about this and making the change > > unconditional in all branches. It's a judgment call, though. > > I think back patching with #ifdefs is better. On Windows etc. the case > has been broken anyway and the fix should only bring benefits to users.
I committed it with #ifdef in 9.1-9.4 and without #ifdef in 9.5 and master. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
