On Wed, Nov 18, 2015 at 12:48 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: >> I suggest that we instead fix ExecParallelFinish() to be idempotent. >> Add a "bool finished" flag to ParallelExecutorInfo and return at once >> if it's already set. Get rid of the exposed >> ExecParallelReinitializeTupleQueues() interface and have >> ExecParallelReinitialize(pei) instead. Have that call >> ReinitializeParallelDSM(), ExecParallelSetupTupleQueues(pei->pcxt, >> true), and set pei->finished = false. I think that would give us a >> slightly cleaner separation of concerns between nodeGather.c and >> execParallel.c. > > Okay, attached patch fixes the issue as per above suggestion.
Thanks, committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
