On Wed, Nov 18, 2015 at 01:21:45PM -0200, Alvaro Herrera wrote: > In my days of Perl, it was starting to become frowned upon to call > subroutines without parenthesizing arguments. Is that no longer the > case?
I've not witnessed those frowns. > Because I notice there are many places in this patch and pre- > existing that call psql with an argument list without parens. And it's > a bit odd because I couldn't find any other subroutine that we're using > in that way. TestLib.pm has unparenthesized calls to "standard_initdb", "start" and "run". 070_dropuser.pl has such calls to "start_test_server" and "psql". > In 005_replay_delay there's a 2s delay configured; then we test whether > something is replayed in 1s. I hate tests that run for a long time, but > is 2s good enough considering that some of our test animals in buildfarm > are really slow? That test will be unreliable, agreed. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
