On Wed, Nov 25, 2015 at 10:19 AM, Magnus Hagander <mag...@hagander.net> wrote:
> Are the values for the log locations really relevant for backup > connections? And if they are, we need to document it :) ISTM we are just > more or less leaking random data out there? > > I'm talking about the actual state=backup connection - not the connection > if we're using -x with pg_basebackup. Where we have output like: > > state | backup > sent_location | 0/0 > write_location | 2/76CE0000 > flush_location | 2/76CC0000 > replay_location | 2/76CBF938 > > I'm thinking those fields should probably all be NULL for state=backup? > > In particular, it seems that in InitWalSenderSlot, we only initialize the sent location. Perhaps this is needed? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/
diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c index 4a4643e..08da433 100644 --- a/src/backend/replication/walsender.c +++ b/src/backend/replication/walsender.c @@ -1962,6 +1962,9 @@ InitWalSenderSlot(void) */ walsnd->pid = MyProcPid; walsnd->sentPtr = InvalidXLogRecPtr; + walsnd->write = InvalidXLogRecPtr; + walsnd->flush = InvalidXLogRecPtr; + walsnd->apply = InvalidXLogRecPtr; walsnd->state = WALSNDSTATE_STARTUP; walsnd->latch = &MyProc->procLatch; SpinLockRelease(&walsnd->mutex);
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
