On Sat, Nov 28, 2015 at 7:53 AM, Alvaro Herrera wrote: > I moved all the initialization code (deleting stuff from environment, > detecting Windows, opening SimpleTie filedescs etc) into BEGIN blocks, > which run earlier than any other code.
Ah, OK. Thanks. That makes visibly the whole set of modules more consistent. > Hmm. I just noticed RewindTest sets $ENV{PGDATABASE} outside BEGIN. Not > sure what to think of that. Could instead pass the database name in > $node->getConnStr() calls, like run_pg_rewind() is already doing. Yes, let's remove that and pass the database name to getConnStr(). > I tried all the t/ tests we have and all of them pass for me. If I'm > able, I will push this on my Sunday late evening, so that I can fix > whatever gets red on Monday first thing ... I have done as well additional tests on Windows and this patch is showing a green status. A separate issue, but as long as we are working on this set of tests: I have noticed that config_default.pl is missing the flag tap_tests in its list. See the patch attached. Could you apply that as well and backpatch? I have as well noticed that RewindTest.pm is missing "1;" on its last line. When this is loaded this would lead to compilation errors. -- Michael
diff --git a/src/tools/msvc/config_default.pl b/src/tools/msvc/config_default.pl index b9f2ff4..e50be7e 100644 --- a/src/tools/msvc/config_default.pl +++ b/src/tools/msvc/config_default.pl @@ -3,7 +3,7 @@ use strict; use warnings; our $config = { - asserts => 0, # --enable-cassert + asserts => 0, # --enable-cassert # integer_datetimes=>1, # --enable-integer-datetimes - on is now default # float4byval=>1, # --disable-float4-byval, on by default @@ -13,18 +13,19 @@ our $config = { # blocksize => 8, # --with-blocksize, 8kB by default # wal_blocksize => 8, # --with-wal-blocksize, 8kB by default # wal_segsize => 16, # --with-wal-segsize, 16MB by default - ldap => 1, # --with-ldap - extraver => undef, # --with-extra-version=<string> - nls => undef, # --enable-nls=<path> - tcl => undef, # --with-tls=<path> - perl => undef, # --with-perl - python => undef, # --with-python=<path> - openssl => undef, # --with-openssl=<path> - uuid => undef, # --with-ossp-uuid - xml => undef, # --with-libxml=<path> - xslt => undef, # --with-libxslt=<path> - iconv => undef, # (not in configure, path to iconv) - zlib => undef # --with-zlib=<path> + ldap => 1, # --with-ldap + extraver => undef, # --with-extra-version=<string> + nls => undef, # --enable-nls=<path> + tap_tests => undef, # --enable-tap-tests + tcl => undef, # --with-tls=<path> + perl => undef, # --with-perl + python => undef, # --with-python=<path> + openssl => undef, # --with-openssl=<path> + uuid => undef, # --with-ossp-uuid + xml => undef, # --with-libxml=<path> + xslt => undef, # --with-libxslt=<path> + iconv => undef, # (not in configure, path to iconv) + zlib => undef # --with-zlib=<path> }; 1;
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers