On Wed, Dec 02, 2015 at 04:33:50PM -0300, Alvaro Herrera wrote: > Noah Misch wrote: > > On Tue, Dec 01, 2015 at 08:11:21PM -0300, Alvaro Herrera wrote: > > > Finally, I ran perltidy on all the files, which strangely changed stuff > > > that I didn't expect it to change. I wonder if this is related to the > > > perltidy version. > > > > The last pgindent run (commit 807b9e0) used perltidy v20090616, and perltidy > > behavior has changed slightly over time. Install that version to do your > > own > > perltidy runs. > > I tried that version, but it seems to emit the same.
git checkout 807b9e0 (find src -name \*.pl -o -name \*.pm ) | sort -u | xargs perltidy --profile=src/tools/pgindent/perltidyrc perltidy v20090616 leaves the working directory clean, but perltidy v20150815 introduces diffs: src/backend/catalog/genbki.pl | 15 ++++++++------- src/bin/pg_basebackup/t/010_pg_basebackup.pl | 2 +- src/tools/msvc/Install.pm | 6 +++--- src/tools/msvc/Mkvcbuild.pm | 2 +- src/tools/msvc/Project.pm | 2 +- src/tools/msvc/Solution.pm | 5 ++--- src/tools/msvc/gendef.pl | 4 ++-- 7 files changed, 18 insertions(+), 18 deletions(-) You see a different result? > How did you figure > that that was the version used, anyway? I asked Bruce at one point. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
