On Fri, Dec 18, 2015 at 3:17 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Thu, Dec 17, 2015 at 11:47 AM, Michael Paquier <michael.paqu...@gmail.com> > wrote: >> make check with pg_upgrade is failing for me: >> Visibility map rewriting test failed >> make: *** [check] Error 1 > > make check with pg_upgrade is done successfully on my environment. > Could you give me more information about this?
Oh, well I see now after digging into your code. You are missing -X when running psql, and until recently psql -c implied -X all the time. The reason why it failed for me is that I have \timing enabled in psqlrc. Actually test.sh needs to be fixed as well, see the attached, this is a separate bug. Could a kind committer look at that if this is acceptable? >> Sawada-san, are you planning to continue working on that? At this >> stage it seems that this patch is not in commitable state and should >> at best be moved to next CF, or at worst returned with feedback. > > Yes, of course. > This patch should be marked as "Move to next CF". OK, done so. -- Michael
pgupgrade-fix.patch
Description: binary/octet-stream
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
