Jeff Janes wrote: > On Sat, Dec 26, 2015 at 8:27 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Michael Paquier <michael.paqu...@gmail.com> writes: > >> On Sat, Dec 26, 2015 at 7:10 AM, Jeff Janes <jeff.ja...@gmail.com> wrote: > >>> brin_summarize_new_values() does not check that it is called on the > >>> correct type of index, nor does it check permissions. > > > >> Yeah, it should have those sanity checks... > > > > Yeah, that is absolutely a must-fix. > > Thanks for committing the fix.
Yes, thanks. > Another issue is: it seems to have no SGML documentation. Is that OK? Hmm, I'm pretty sure I documented it somewhere. If this can wait till Monday, I'll have a look by then. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
