Peter Geoghegan wrote: > We lack SortSupport for many character-like-type cases. In full, the > cases within the core system are:
You're stealthily introducing a new abstraction called "string", including a typedef and DatumGetString support macros. Is that really necessary? Shouldn't it be discussed specifically? I don't necessarily oppose it as is, mainly because it's limited to within varlena.c for now, but I'm not sure it'd okay to make it more public. Also, there's a lot of churn in this patch to just remove tss to sss. Can't we just keep the original variable name? -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
