On 01/13/2016 12:13 PM, Tom Lane wrote:
Simon Riggs <si...@2ndquadrant.com> writes:
On 13 January 2016 at 14:48, Noah Misch <n...@leadboat.com> wrote:
I've noticed commits, from a few of you, carrying pgindent changes to lines
the patch would not otherwise change.
Could we review again why this matters?
Basically this is trading off convenience of the committer (all of the
alternatives Noah mentions are somewhat annoying) versus the convenience
of post-commit reviewers. I'm not sure that his recommendation is the
best trade-off, nor that the situation is precisely comparable to
pre-commit review. There definitely will be pre-commit review, there
may or may not be any post-commit review.
I'm willing to go with the "separate commit to reindent individual files"
approach if there's a consensus that that makes for a cleaner git history.
But I'm not 100% convinced it matters.
I do think it makes life easier when going through the git history if
semantic changes are separated from formatting changes.
cheers
andrew
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
