On Sun, Jan 10, 2016 at 4:24 AM, Julien Rouhaud
<julien.rouh...@dalibo.com> wrote:
> On 29/12/2015 00:30, Jeff Janes wrote:
>> On Wed, Nov 25, 2015 at 9:29 AM, Jeff Janes <jeff.ja...@gmail.com> wrote:
>>>
>>> I'll prepare a patch for core for the January commitfest, and see if
>>> it flies.  If not, there is always the extension to fall back to.
>>
>> Here is an updated patch.  I've added type and permission checks,
>> docs, and some regression tests.
>>
>
> I just reviewed it. Patch applies cleanly, everything works as intended,
> including regression tests.
>
> I think the function should be declared as strict.

OK.  I see that brin_summarize_new_values, which I modeled this on,
was recently changed to be strict.  So I've changed this the same way.

>
> Also, there are some trailing whitespaces in the documentation diff.

Fixed.  I also added the DESC to the pg_proc entry, which I somehow
missed before.

Thanks,

Jeff

Attachment: gin_clean_pending_user_v003.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to