Stas Kelvich wrote: > While this patch touches quite sensible part of postgres replay and there is > some rarely used code paths, I wrote shell script to setup master/slave > replication and test different failure scenarios that can happened with > instances. Attaching this file to show test scenarios that I have tested and > more importantly to show what I didn’t tested. Particularly I failed to > reproduce situation where StandbyTransactionIdIsPrepared() is called, may be > somebody can suggest way how to force it’s usage. Also I’m not too sure about > necessity of calling cache invalidation callbacks during > XlogRedoFinishPrepared(), I’ve marked this place in patch with 2REVIEWER > comment.
I think this is the third thread in which I say this: We need to push Michael Paquier's recovery test framework, then convert your test script to that. That way we can put your tests in core. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
