Victor Wagner wrote: > On Fri, 22 Jan 2016 16:36:15 -0300 > Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > > > You're editing the expected file for the libpq-regress thingy, but you > > haven't added any new lines to test the new capability. I think it'd > > be good to add some there. (I already said this earlier in the > > thread; is there any reason you ignored it the first time?) > > I seriously doubt that this program can be used to test new > capabilities. > > All it does, it calls PQconninfoParse and than examines some fields of > PGconn structure.
Ah, you're right, I didn't remember that. > If I add some new uris, than only thing I can test is that comma is > properly copied from the URI to this field. And may be that some syntax > errors are properly detected. Yeah, we should do that. > So, I think that new functionality need other approach for testing. > There should be test of real connection to real temporary cluster. > Probably, based on Perl TAP framework which is actively used in the > Postgres recently. Yes, agreed. So please have a look at that one and share your opinion about it. It'd be useful. Meanwhile I'm moving the patch to the next commitfest. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
