On Sun, Jan 24, 2016 at 7:56 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > On Sat, Jan 23, 2016 at 12:59 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: >> Here I attached updated patch with additional combine function for >> two stage aggregates also. > > A wrong combine function was added in pg_aggregate.h in the earlier > patch that leading to > initdb problem. Corrected one is attached.
I'm not entirely sure I know what's going on here, but I'm pretty sure that it makes no sense for the new float8_pl function to reject non-aggregate callers at the beginning and then have a comment at the end indicating what it does when not invoked as an aggregate. Similarly for the other new function. It would be a lot more clear what this patch was trying to accomplish if the new functions had header comments explaining their purpose - not what they do, but why they exist. float8_regr_pl is labeled in pg_proc.h as an aggregate transition function, but I'm wondering if it should say combine function. The changes to pg_aggregate.h include a large number of whitespace-only changes which are unacceptable. Please change only the lines that need to be changed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
