On Fri, Feb 12, 2016 at 9:56 AM, Andres Freund <and...@anarazel.de> wrote: > On 2016-02-10 23:26:20 -0500, Robert Haas wrote: >> I think the part about whacking around the FDW API is a little more >> potentially objectionable to others, so I want to hold off doing that >> unless a few more people chime in with +1. Perhaps we could start a >> new thread to talk about that specific idea. This is useful even >> without that, though. > > FWIW, I can delete a couple hundred lines of code from citusdb thanks to > this... > > A quick questions about what you committed: > >> @@ -527,10 +532,17 @@ extern PGDLLIMPORT Node *newNodeMacroHolder; >> */ >> extern char *nodeToString(const void *obj); >> >> +struct Bitmapset; /* not to include bitmapset.h here */ >> +struct StringInfoData; /* not to include stringinfo.h here */ >> +extern void outToken(struct StringInfoData *str, const char *s); >> +extern void outBitmapset(struct StringInfoData *str, >> + const struct Bitmapset *bms); >> + >> /* >> * nodes/{readfuncs.c,read.c} >> */ >> extern void *stringToNode(char *str); >> +extern struct Bitmapset *readBitmapset(void); > > why exactly did you expose read/writeBitmapset(), and nothing else? > Afaics a lot of the other read routines are also pretty necessary from > the outside?
Because that's what KaiGai submitted and I had no reason to second-guess it. I'm happy to expose other stuff along similar lines if somebody writes a patch for it. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers