Hi 2016-03-01 18:48 GMT+01:00 Catalin Iacob <iacobcata...@gmail.com>:
> On 3/1/16, Pavel Stehule <pavel.steh...@gmail.com> wrote: > >> I though about it before and I prefer variant with possibility to enter > >> message as keyword parameter. > > That's also ok, but indeed with a check that it's not specified twice > which I see you already added. > > > I merged your patches without @3 (many thanks for it). Instead @3 I > > disallow double message specification (+regress test) > > Great, welcome. Ran the tests for plpython-enhanced-error-06 again on > 2.4 - 2.7 and 3.5 versions and they passed. > > I see the pfree you added isn't allowed on a NULL pointer but as far > as I see message is guaranteed not to be NULL as dgettext never > returns NULL. > > I'll mark this Ready for Committer. > Thank you very much Nice day Pavel
