On Thu, Mar 3, 2016 at 12:08 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Ashutosh Bapat <ashutosh.ba...@enterprisedb.com> writes: >> On Thu, Mar 3, 2016 at 7:27 AM, Michael Paquier <michael.paqu...@gmail.com> >> wrote: >>> Per explain.c, this looks inconsistent to me. Shouldn't NULLS LAST be >>> applied only if DESC is used in this ORDER BY clause? > >> ... In this case we are constructing a query to be >> sent to the foreign server and it's better not to leave the defaults to be >> interpreted by the foreign server; in case it interprets them in different >> fashion. get_rule_orderby() also explicitly adds these options. > > Yeah, I agree that we don't need to go out of our way to make the query > succinct here. Explicitness is easier and safer too, so why not?
+1. So, committed Ashutosh's version. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
