On Wed, Mar 9, 2016 at 7:02 AM, Tomas Vondra <tomas.von...@2ndquadrant.com> wrote: > Hi, > > thanks for the feedback. Attached is v14 of the patch series, fixing > most of the points you've raised.
Hi Tomas, Applied to aa09cd242fa7e3a694a31f, I still get the seg faults in make check if I configure without --enable-cassert. With --enable-cassert, it passes the regression test. I got the core file, configured and compiled with: CFLAGS="-fno-omit-frame-pointer" --enable-debug The first core dump is on this statement: -- check explain (expect bitmap index scan, not plain index scan) INSERT INTO functional_dependencies SELECT i/10000, i/20000, i/40000 FROM generate_series(1,1000000) s(i); bt #0 0x00000000006e1160 in cost_qual_eval (cost=0x2494418, quals=0x2495550, root=0x2541b88) at costsize.c:3181 #1 0x00000000006e1ee5 in set_baserel_size_estimates (root=0x2541b88, rel=0x2494300) at costsize.c:3754 #2 0x00000000006d37e8 in set_plain_rel_size (root=0x2541b88, rel=0x2494300, rte=0x247e660) at allpaths.c:480 #3 0x00000000006d353d in set_rel_size (root=0x2541b88, rel=0x2494300, rti=1, rte=0x247e660) at allpaths.c:350 #4 0x00000000006d338f in set_base_rel_sizes (root=0x2541b88) at allpaths.c:270 #5 0x00000000006d3233 in make_one_rel (root=0x2541b88, joinlist=0x2494628) at allpaths.c:169 #6 0x000000000070012e in query_planner (root=0x2541b88, tlist=0x2541e58, qp_callback=0x7048d4 <standard_qp_callback>, qp_extra=0x7ffefa6474e0) at planmain.c:246 #7 0x0000000000702a33 in grouping_planner (root=0x2541b88, inheritance_update=0 '\000', tuple_fraction=0) at planner.c:1647 #8 0x0000000000701310 in subquery_planner (glob=0x2541af8, parse=0x246a838, parent_root=0x0, hasRecursion=0 '\000', tuple_fraction=0) at planner.c:740 #9 0x000000000070055b in standard_planner (parse=0x246a838, cursorOptions=256, boundParams=0x0) at planner.c:290 #10 0x000000000070023f in planner (parse=0x246a838, cursorOptions=256, boundParams=0x0) at planner.c:160 #11 0x00000000007b8bf9 in pg_plan_query (querytree=0x246a838, cursorOptions=256, boundParams=0x0) at postgres.c:798 #12 0x00000000005d1967 in ExplainOneQuery (query=0x246a838, into=0x0, es=0x246a778, queryString=0x2443d80 "EXPLAIN (COSTS off)\n SELECT * FROM mcv_list WHERE a = 10 AND b = 5;", params=0x0) at explain.c:350 #13 0x00000000005d16a3 in ExplainQuery (stmt=0x2444f90, queryString=0x2443d80 "EXPLAIN (COSTS off)\n SELECT * FROM mcv_list WHERE a = 10 AND b = 5;", params=0x0, dest=0x246a6e8) at explain.c:244 #14 0x00000000007c0afb in standard_ProcessUtility (parsetree=0x2444f90, queryString=0x2443d80 "EXPLAIN (COSTS off)\n SELECT * FROM mcv_list WHERE a = 10 AND b = 5;", context=PROCESS_UTILITY_TOPLEVEL, params=0x0, dest=0x246a6e8, completionTag=0x7ffefa647b60 "") at utility.c:659 #15 0x00000000007c0299 in ProcessUtility (parsetree=0x2444f90, queryString=0x2443d80 "EXPLAIN (COSTS off)\n SELECT * FROM mcv_list WHERE a = 10 AND b = 5;", context=PROCESS_UTILITY_TOPLEVEL, params=0x0, dest=0x246a6e8, completionTag=0x7ffefa647b60 "") at utility.c:335 #16 0x00000000007bf47b in PortalRunUtility (portal=0x23ed510, utilityStmt=0x2444f90, isTopLevel=1 '\001', dest=0x246a6e8, completionTag=0x7ffefa647b60 "") at pquery.c:1183 #17 0x00000000007bf1ce in FillPortalStore (portal=0x23ed510, isTopLevel=1 '\001') at pquery.c:1057 #18 0x00000000007beb19 in PortalRun (portal=0x23ed510, count=9223372036854775807, isTopLevel=1 '\001', dest=0x253f6c0, altdest=0x253f6c0, completionTag=0x7ffefa647d40 "") at pquery.c:781 #19 0x00000000007b90ae in exec_simple_query (query_string=0x2443d80 "EXPLAIN (COSTS off)\n SELECT * FROM mcv_list WHERE a = 10 AND b = 5;") at postgres.c:1094 #20 0x00000000007bcfac in PostgresMain (argc=1, argv=0x23d5070, dbname=0x23d4e48 "regression", username=0x23d4e30 "jjanes") at postgres.c:4021 #21 0x0000000000745a62 in BackendRun (port=0x23f4110) at postmaster.c:4258 #22 0x00000000007451d6 in BackendStartup (port=0x23f4110) at postmaster.c:3932 #23 0x0000000000741ab7 in ServerLoop () at postmaster.c:1690 #24 0x00000000007411c0 in PostmasterMain (argc=8, argv=0x23d3f20) at postmaster.c:1298 #25 0x0000000000690026 in main (argc=8, argv=0x23d3f20) at main.c:223 Cheers, Jeff -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers