Hi, Thank you very much for committing this feature. > -----Original Message----- > From: Robert Haas [mailto:robertmh...@gmail.com] > Sent: Thursday, March 10, 2016 2:17 AM > To: Amit Langote <langote_amit...@lab.ntt.co.jp> > Cc: Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp>; Amit Langote > <amitlangot...@gmail.com>; SPS ポクレ ヴィナヤック(三技術) > <poku...@pm.nttdata.co.jp>; pgsql-hackers@postgresql.org; SPS 坂野 昌 > 平(三技術) <ban...@nttdata.co.jp> > Subject: Re: [HACKERS] [PROPOSAL] VACUUM Progress Checker. > > On Wed, Mar 9, 2016 at 2:37 AM, Amit Langote > <langote_amit...@lab.ntt.co.jp> wrote: > > On 2016/03/09 10:11, Amit Langote wrote: > >> The attached revision addresses above and one of Horiguchi-san's > >> comments in his email yesterday. > > > > I fixed one more issue in 0002 per Horiguchi-san's comment. Sorry > > about so many versions. > > I've committed 0001 with heavy revisions. Just because we don't need an > SQL-visible function to clear the command progress doesn't mean we don't > need to clear it at all; rather, it has to happen automatically. > I also did a bunch of identifier renaming, added datid to the view output, > adjusted the comments, and so on. Please rebase the remainder of the > series. Thanks. Some minor typos need to fix. +/*----------- + * pgstat_progress_start_command() - + * + * Set st_command in own backend entry. Also, zero-initialize + * st_progress_param array. + *----------- + */ In the description we need to use st_progress_command instead of st_command.
+/*----------- + * pgstat_progress_end_command() - + * + * Update index'th member in st_progress_param[] of own backend entry. + *----------- + */ Here also need to change the description. Regards, Vinayak Pokale -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
