On 12 Mar 2016 10:58 pm, "Tom Lane" <t...@sss.pgh.pa.us> wrote: > > I wrote: > > That's confusing because it implies that -fno-common is the default, > > which it evidently is not. But anyway, my diagnosis is that you're > > breaking something about the linker's behavior with that switch.
> I shall get rid of the const-ness, as well as the lame casting away > of it, and I think I will also go make buildfarm member longfin use > "-fno-common". It is truly sad that we apparently have no test > machine that enforces that const means const ... It looks like this would also be useful for catching any mistakes where we might have defined a variable in two different files or missed an "extern". Though I'm not sure the failures will be very obvious.