On 16 March 2016 at 23:54, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > On Wed, Mar 16, 2016 at 8:34 AM, David Rowley > <david.row...@2ndquadrant.com> wrote: >> Yes me too, so I spent several hours yesterday writing all of the >> combine functions and serialisation/deserialisation that are required >> for all of SUM(), AVG() STDDEV*(). I also noticed that I had missed >> using some existing functions for bool_and() and bool_or() so I added >> those to pg_aggregate.h. I'm just chasing down a crash bug on >> HAVE_INT128 enabled builds, so should be posting a patch quite soon. I >> didn't touch the FLOAT4 and FLOAT8 aggregates as I believe Haribabu >> has a patch for that over on the parallel aggregate thread. I've not >> looked at it in detail yet. > > The additional combine function patch that I posted handles all float4 and > float8 aggregates. There is an OID conflict with the latest source code, > I will update the patch and post it in that thread.
Thanks! I just send a series of patches which add a whole host of serial/deserial functions, and a patch which adds some documentation. Maybe you could base your patch on the 0005 patch, and update the documents to remove the "All types apart from floating-point types" text and replace that with "Yes". -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers