On Wed, Mar 16, 2016 at 2:05 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > "Joshua D. Drake" <j...@commandprompt.com> writes: >> Hello, >> fd.c[1] will remove files from pgsql_tmp on a restart but not a >> crash-restart per this comment: > >> /* >> * NOTE: we could, but don't, call this during a post-backend-crash restart >> * cycle. The argument for not doing it is that someone might want to >> examine >> * the temp files for debugging purposes. This does however mean that >> * OpenTemporaryFile had better allow for collision with an existing temp >> * file name. >> */ > >> I understand that this is designed this way. I think it is a bad idea >> because: > > Possible compromise: remove files only in non-Assert builds?
That sorta seems like tying two things together that aren't obviously related. I think building with --enable-cassert is support to enable debugging cross-checks, not change behavior. I would vote for removing them always, and if somebody doesn't want to remove them, well then they can comment the code out. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
