At 2016-03-21 12:04:40 +0530, a...@2ndquadrant.com wrote:
>
> I'll write up a patch for this. Thanks for the suggestions.
Here's a patch to implement ALTER FUNCTION x DEPENDS ON EXTENSION y.
The changes to functioncmds.c:AlterFunction were less intrusive than I
had originally feared.
-- Abhijit
>From 722f23b75369f035f094753e47663c50580b052c Mon Sep 17 00:00:00 2001
From: Abhijit Menon-Sen <a...@2ndquadrant.com>
Date: Tue, 1 Mar 2016 06:44:28 +0530
Subject: =?UTF-8?q?Add=20DEPENDENCY=5FAUTO=5FEXTENSION/ALTER=20FUNCTION=20?=
=?UTF-8?q?=E2=80=A6=20DEPENDS=20ON=20EXTENSION=20=E2=80=A6?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The new dependency type is used for functions that require an extension
to operate, but do not actually belong to the extension per se and, in
particular, should not be ignored by pg_dump. The new command allows a
function to be marked as depending on an extension in this way.
---
doc/src/sgml/catalogs.sgml | 13 +++++++++++++
src/backend/catalog/dependency.c | 2 ++
src/backend/commands/functioncmds.c | 31 ++++++++++++++++++++++++++++---
src/backend/parser/gram.y | 7 ++++++-
src/include/catalog/dependency.h | 9 ++++++++-
src/include/parser/kwlist.h | 1 +
6 files changed, 58 insertions(+), 5 deletions(-)
diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
index 951f59b..189b771 100644
--- a/doc/src/sgml/catalogs.sgml
+++ b/doc/src/sgml/catalogs.sgml
@@ -2864,6 +2864,19 @@
</para>
</listitem>
</varlistentry>
+
+ <varlistentry>
+ <term><symbol>DEPENDENCY_AUTO_EXTENSION</> (<literal>x</>)</term>
+ <listitem>
+ <para>
+ The dependent object is not a member of the extension that is the
+ referenced object (and so should not be ignored by pg_dump), but
+ cannot function without it and should be dropped when the
+ extension itself is. The dependent object may be dropped on its
+ own as well.
+ </para>
+ </listitem>
+ </varlistentry>
</variablelist>
Other dependency flavors might be needed in future.
diff --git a/src/backend/catalog/dependency.c b/src/backend/catalog/dependency.c
index c48e37b..a284bed 100644
--- a/src/backend/catalog/dependency.c
+++ b/src/backend/catalog/dependency.c
@@ -587,6 +587,7 @@ findDependentObjects(const ObjectAddress *object,
{
case DEPENDENCY_NORMAL:
case DEPENDENCY_AUTO:
+ case DEPENDENCY_AUTO_EXTENSION:
/* no problem */
break;
case DEPENDENCY_INTERNAL:
@@ -786,6 +787,7 @@ findDependentObjects(const ObjectAddress *object,
subflags = DEPFLAG_NORMAL;
break;
case DEPENDENCY_AUTO:
+ case DEPENDENCY_AUTO_EXTENSION:
subflags = DEPFLAG_AUTO;
break;
case DEPENDENCY_INTERNAL:
diff --git a/src/backend/commands/functioncmds.c b/src/backend/commands/functioncmds.c
index a745d73..b0f0f88 100644
--- a/src/backend/commands/functioncmds.c
+++ b/src/backend/commands/functioncmds.c
@@ -41,6 +41,7 @@
#include "catalog/objectaccess.h"
#include "catalog/pg_aggregate.h"
#include "catalog/pg_cast.h"
+#include "catalog/pg_extension.h"
#include "catalog/pg_language.h"
#include "catalog/pg_namespace.h"
#include "catalog/pg_proc.h"
@@ -50,6 +51,7 @@
#include "catalog/pg_type_fn.h"
#include "commands/alter.h"
#include "commands/defrem.h"
+#include "commands/extension.h"
#include "commands/proclang.h"
#include "miscadmin.h"
#include "optimizer/var.h"
@@ -466,7 +468,8 @@ compute_common_attribute(DefElem *defel,
List **set_items,
DefElem **cost_item,
DefElem **rows_item,
- DefElem **parallel_item)
+ DefElem **parallel_item,
+ DefElem **extdepend_item)
{
if (strcmp(defel->defname, "volatility") == 0)
{
@@ -521,6 +524,13 @@ compute_common_attribute(DefElem *defel,
*parallel_item = defel;
}
+ else if (strcmp(defel->defname, "extdepend") == 0)
+ {
+ if (*extdepend_item)
+ goto duplicate_error;
+
+ *extdepend_item = defel;
+ }
else
return false;
@@ -682,7 +692,8 @@ compute_attributes_sql_style(List *options,
&set_items,
&cost_item,
&rows_item,
- ¶llel_item))
+ ¶llel_item,
+ NULL))
{
/* recognized common option */
continue;
@@ -1179,6 +1190,7 @@ AlterFunction(AlterFunctionStmt *stmt)
DefElem *cost_item = NULL;
DefElem *rows_item = NULL;
DefElem *parallel_item = NULL;
+ DefElem *extdepend_item = NULL;
ObjectAddress address;
rel = heap_open(ProcedureRelationId, RowExclusiveLock);
@@ -1217,7 +1229,8 @@ AlterFunction(AlterFunctionStmt *stmt)
&set_items,
&cost_item,
&rows_item,
- ¶llel_item) == false)
+ ¶llel_item,
+ &extdepend_item) == false)
elog(ERROR, "option \"%s\" not recognized", defel->defname);
}
@@ -1303,6 +1316,18 @@ AlterFunction(AlterFunctionStmt *stmt)
heap_close(rel, NoLock);
heap_freetuple(tup);
+ if (extdepend_item)
+ {
+ char *extensionName;
+ Oid extensionOid;
+ ObjectAddress extAddr;
+
+ extensionName = defGetString(extdepend_item);
+ extensionOid = get_extension_oid(extensionName, false);
+ ObjectAddressSet(extAddr, ExtensionRelationId, extensionOid);
+ recordDependencyOn(&address, &extAddr, DEPENDENCY_AUTO_EXTENSION);
+ }
+
return address;
}
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
index a74fb77..c5f3aa7 100644
--- a/src/backend/parser/gram.y
+++ b/src/backend/parser/gram.y
@@ -577,7 +577,7 @@ static Node *makeRecursiveViewSelect(char *relname, List *aliases, Node *query);
CURRENT_TIME CURRENT_TIMESTAMP CURRENT_USER CURSOR CYCLE
DATA_P DATABASE DAY_P DEALLOCATE DEC DECIMAL_P DECLARE DEFAULT DEFAULTS
- DEFERRABLE DEFERRED DEFINER DELETE_P DELIMITER DELIMITERS DESC
+ DEFERRABLE DEFERRED DEFINER DELETE_P DELIMITER DELIMITERS DEPENDS DESC
DICTIONARY DISABLE_P DISCARD DISTINCT DO DOCUMENT_P DOMAIN_P DOUBLE_P DROP
EACH ELSE ENABLE_P ENCODING ENCRYPTED END_P ENUM_P ESCAPE EVENT EXCEPT
@@ -7082,6 +7082,10 @@ common_func_opt_item:
{
$$ = makeDefElem("parallel", (Node *)makeString($2));
}
+ | DEPENDS ON EXTENSION name
+ {
+ $$ = makeDefElem("extdepend", (Node *)makeString($4));
+ }
;
createfunc_opt_item:
@@ -13706,6 +13710,7 @@ unreserved_keyword:
| DELETE_P
| DELIMITER
| DELIMITERS
+ | DEPENDS
| DICTIONARY
| DISABLE_P
| DISCARD
diff --git a/src/include/catalog/dependency.h b/src/include/catalog/dependency.h
index 049bf9f..380f74a 100644
--- a/src/include/catalog/dependency.h
+++ b/src/include/catalog/dependency.h
@@ -61,6 +61,12 @@
* created only during initdb. The fields for the dependent object
* contain zeroes.
*
+ * DEPENDENCY_AUTO_EXTENSION ('x'): the dependent object is not a member
+ * of the extension that is the referenced object (and so should not be
+ * ignored by pg_dump), but cannot function without it and should be
+ * dropped when the extension itself is. The dependent object may be
+ * dropped on its own as well.
+ *
* Other dependency flavors may be needed in future.
*/
@@ -70,7 +76,8 @@ typedef enum DependencyType
DEPENDENCY_AUTO = 'a',
DEPENDENCY_INTERNAL = 'i',
DEPENDENCY_EXTENSION = 'e',
- DEPENDENCY_PIN = 'p'
+ DEPENDENCY_PIN = 'p',
+ DEPENDENCY_AUTO_EXTENSION = 'x'
} DependencyType;
/*
diff --git a/src/include/parser/kwlist.h b/src/include/parser/kwlist.h
index 6e1e820..709a288 100644
--- a/src/include/parser/kwlist.h
+++ b/src/include/parser/kwlist.h
@@ -125,6 +125,7 @@ PG_KEYWORD("definer", DEFINER, UNRESERVED_KEYWORD)
PG_KEYWORD("delete", DELETE_P, UNRESERVED_KEYWORD)
PG_KEYWORD("delimiter", DELIMITER, UNRESERVED_KEYWORD)
PG_KEYWORD("delimiters", DELIMITERS, UNRESERVED_KEYWORD)
+PG_KEYWORD("depends", DEPENDS, UNRESERVED_KEYWORD)
PG_KEYWORD("desc", DESC, RESERVED_KEYWORD)
PG_KEYWORD("dictionary", DICTIONARY, UNRESERVED_KEYWORD)
PG_KEYWORD("disable", DISABLE_P, UNRESERVED_KEYWORD)
--
2.1.4
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
