On Wed, Mar 23, 2016 at 11:01 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Michael Paquier <michael.paqu...@gmail.com> writes: >> That's ugly. We should actually use TextDatumGetCString because the >> index is stored as text here via a Datum, and then it is converted >> back to an integer. So I propose instead the simple patch attached >> that fixes the failure for me. Could you check if that works for you? > > Yeah, this seems better. But that code needs review anyway, as it's using > elog() for user-facing error conditions, and I'm thinking the error texts > could use a bit of attention from a native English speaker.
Thanks. The bug fix is 384dfbd, and the improvements of error messages is ea4b8bd. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers