Christian Ullrich <ch...@chrullrich.net> writes:
> * Tom Lane wrote:
>> But then, should not this code make sure that errno *always* gets set?

> A library function that does not fail does not touch errno.

Right, I meant "always in the error path".

>> I'd be inclined to think we should use _dosmaperr(), too, rather than
>> hand-coding it.

> Yes, of course. If only I had known about it ...
> New patch attached.

This looks good, will push shortly.

                        regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to