On 2016-04-01 20:18:29 +1300, David Rowley wrote: > On 1 April 2016 at 17:30, Tom Lane <t...@sss.pgh.pa.us> wrote: > > David Rowley <david.row...@2ndquadrant.com> writes: > >> The attached fixes an error message which is incorrectly using an > >> unsigned format specifier instead of a signed one. > > > > Really though, what > > astonishes me about this example is that we allow indexes at all on > > system columns other than OID. None of the other ones can possibly > > have either a use-case or sensible semantics, can they? We certainly > > would not stop to update indexes after changing xmax, for example. > > As for this part. I really don't see how we could disable this without > breaking pg_restore for database who have such indexes. My best > thought is to add some sort of warning during CREATE INDEX, like we do > for HASH indexes.
As they're currently already not working correctly as indexes, I don't see throwing an error during pg_restore as being overly harmful. Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
