On 5/3/16 3:10 PM, Dean Rasheed wrote:
On 3 May 2016 at 16:52, Peter Eisentraut
<peter.eisentr...@2ndquadrant.com> wrote:
I would change appendReloptionsArrayAH() to a function and keep AH as the
first argument (similar to other functions that take such a handle).

I can understand changing it to a function, but I don't think AH
should be the first argument. All other append*() functions that
append to a buffer have the buffer as the first argument, including
the appendStringLiteralAH() macro on which this is based.

Well, all the functions that take archive handles have that as the first argument, so how do we consolidate that?

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to