Robert Haas <robertmh...@gmail.com> writes: > On Sun, May 22, 2016 at 4:16 PM, Piotr Stefaniak > <postg...@piotr-stefaniak.me> wrote: >> I think I've managed to improve pg_bsd_indent's handling of two types of >> cases.
> Wow, that seems pretty great. I haven't scrutinized your changes to > pg_bsd_indent, but effect_on_pg.diff looks like a large improvement. I'm excited about this too, not least because it suggests that maybe bsdindent isn't quite as opaque as it appears. I'd love to see a fix for its brain damage around function pointer typedef formatting, too. Assuming this patch withstands more careful review, we will need to think about project policy for how/when to apply such fixes. The last time we made any real change to pgindent's behavior was when we changed its wrapping of comment blocks back around 8.1 ... and I cursed that decision at least weekly for the next five years, because it caused constant back-patching pain. If we make a change like this, I think we should *strongly* consider reindenting all the live back branches along with HEAD. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers