On Fri, May 27, 2016 at 6:07 PM, Andrew Gierth <and...@tao11.riddles.org.uk> wrote: > copyParamList does not respect from->paramMask, in what looks to me like > an obvious oversight: > > retval->paramMask = NULL; > [...] > /* Ignore parameters we don't need, to save cycles and space. */ > if (retval->paramMask != NULL && > !bms_is_member(i, retval->paramMask)) > > retval->paramMask is never set to anything not NULL in this function, > so surely that should either be initializing it to from->paramMask, or > checking from->paramMask in the conditional?
Oh, dear. I think you are right. I'm kind of surprised this didn't provoke a test failure somewhere. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
