On Fri, May 27, 2016 at 10:36 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Sat, May 28, 2016 at 12:28 AM, Andres Freund <and...@anarazel.de> wrote: >> contain_volatile_functions_walker is duplicated, near entirely, in >> contain_volatile_functions_not_nextval_walker. > > Previously, I also had same observation. > >> Wouldn't it have been better not to duplicate, and keep a flag about >> ignoring nextval in the context variable? > > makes sense. +1 for doing it in the way as you are suggesting.
+1 from me, too. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
