On Fri, Jul 8, 2016 at 4:04 PM, Magnus Hagander <mag...@hagander.net> wrote: > On Friday, July 8, 2016, Michael Paquier <michael.paqu...@gmail.com> wrote: >> >> Hi all, >> >> Fujii-san has reminded me of the fact that we do not show in \df+ the >> parallel status of a function. The output of \df+ is already very >> large, so I guess that any people mentally sane already use it with >> the expanded display mode, and it may not matter adding more >> information. >> Thoughts about adding this piece of information? >> > > Seems like a good idea to me. It's going to be useful in debugging
Okay. Here we go. I named the column for the parallel information "Parallelism". -- Michael
diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml index aeffd63..e36efc3 100644 --- a/doc/src/sgml/ref/psql-ref.sgml +++ b/doc/src/sgml/ref/psql-ref.sgml @@ -1381,7 +1381,7 @@ testdb=> modifier to include system objects. If the form <literal>\df+</literal> is used, additional information about each function is shown, including security classification, - volatility, owner, language, source code and description. + volatility, parallelism, owner, language, source code and description. </para> <tip> diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c index 2cdc5ac..8d0e655 100644 --- a/src/bin/psql/describe.c +++ b/src/bin/psql/describe.c @@ -298,7 +298,7 @@ describeFunctions(const char *functypes, const char *pattern, bool verbose, bool PQExpBufferData buf; PGresult *res; printQueryOpt myopt = pset.popt; - static const bool translate_columns[] = {false, false, false, false, true, true, true, false, false, false, false}; + static const bool translate_columns[] = {false, false, false, false, true, true, true, true, false, false, false, false}; if (strlen(functypes) != strspn(functypes, "antwS+")) { @@ -417,6 +417,11 @@ describeFunctions(const char *functypes, const char *pattern, bool verbose, bool " WHEN p.provolatile = 's' THEN '%s'\n" " WHEN p.provolatile = 'v' THEN '%s'\n" " END as \"%s\"" + ",\n CASE\n" + " WHEN p.proparallel = 'r' THEN '%s'\n" + " WHEN p.proparallel = 's' THEN '%s'\n" + " WHEN p.proparallel = 'u' THEN '%s'\n" + " END as \"%s\"" ",\n pg_catalog.pg_get_userbyid(p.proowner) as \"%s\",\n" " l.lanname as \"%s\",\n" " p.prosrc as \"%s\",\n" @@ -428,6 +433,10 @@ describeFunctions(const char *functypes, const char *pattern, bool verbose, bool gettext_noop("stable"), gettext_noop("volatile"), gettext_noop("Volatility"), + gettext_noop("restricted"), + gettext_noop("safe"), + gettext_noop("unsafe"), + gettext_noop("Parallelism"), gettext_noop("Owner"), gettext_noop("Language"), gettext_noop("Source code"),
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers