On Mon, Jul 11, 2016 at 3:05 PM, Michael Paquier <michael.paqu...@gmail.com> wrote:
> On Mon, Jul 11, 2016 at 7:01 PM, Magnus Hagander <mag...@hagander.net> > wrote: > > But isn't this also a pre-existing bug in 9.5? Or did we change something > > else that suddenly made it visible? > > What has been patched here is a defect caused by pg_start_backup(), > and not pg_basebackup. In the case of the latter, ThisTimelineID gets > set by GetStandbyFlushRecPtr() in the context of the WAL sender used > to send the base backup. In short, this is only a defect of 9.6, where > pg_start_backup() can be used on standbys for the first time for > non-exclusive backups. > > So the issue does not actually pre-exist, GetStandbyFlushRecPtr() > playing its role to set up the timeline ID. Ah, that's where we gt it from. Gotcha, makes sense. Thanks for confirming! -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/