Hello Peter,
number of transactions per client: 1000
-latency average = 15.844 ms
+latency average: 15.844 ms
tps = 618.764555 (including connections establishing)
I think what you have here is that colons separate input parameters and
equal signs separate result output. So I think it's OK the way it is.
Hmmm... Then other measures displayed are not all consistent with this
theory.
Also there is still the bug under -t which displays a 0 latency.
The attached patch still fixes that and make it consistent the other way
around, i.e. by using "=" for latency. I switched to use ":" for weight
which is an input parameter. I let ":" when there is a long sentence to
describe the figure displayed, more on aesthetical grounds.
Maybe a better improvement would be introducing section headings like
"test parameters" and "test results".
This would add more lines to the report, to sure how desirable it is.
--
Fabien.
diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
index 87fb006..af1169a 100644
--- a/src/bin/pgbench/pgbench.c
+++ b/src/bin/pgbench/pgbench.c
@@ -3291,9 +3291,9 @@ printResults(TState *threads, StatsData *total, instr_time total_time,
if (throttle_delay || progress || latency_limit)
printSimpleStats("latency", &total->latency);
else
- /* only an average latency computed from the duration is available */
- printf("latency average: %.3f ms\n",
- 1000.0 * duration * nclients / total->cnt);
+ /* no measure, show average latency computed from run time */
+ printf("latency average = %.3f ms\n",
+ 1000.0 * time_include * nclients / total->cnt);
if (throttle_delay)
{
@@ -3319,7 +3319,7 @@ printResults(TState *threads, StatsData *total, instr_time total_time,
{
if (num_scripts > 1)
printf("SQL script %d: %s\n"
- " - weight = %d (targets %.1f%% of total)\n"
+ " - weight: %d (targets %.1f%% of total)\n"
" - " INT64_FORMAT " transactions (%.1f%% of total, tps = %f)\n",
i + 1, sql_script[i].desc,
sql_script[i].weight,
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
